Skip to content

Combine the number range error handlers #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

Conversation

jdesrosiers
Copy link
Collaborator

This combines the error handlers for the minimum/exclusvieMinimum/maximum/exclusiveMaximum into one error handler in order to produce better messaging for related keywords. We can use this strategy for a few other combinations of keywords as well.

Copy link
Collaborator

@arpitkuriyal arpitkuriyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good. I'll now do for remaining pairs of keywords.

@arpitkuriyal arpitkuriyal merged commit c11aab9 into main Aug 12, 2025
2 checks passed
@arpitkuriyal
Copy link
Collaborator

spotted a typo error in the en-US.ftl file
Screenshot 2025-08-12 at 3 47 05 PM
It should be number-error-maximum = less than {$maximum}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants