Skip to content

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Oct 31, 2025

PR description

Looking through history, equals was added in #8013 so I don't think this class ever had a hashCode implementation.

Fixed Issue(s)

This fixes (several) warnings in CodeQL, since Address class defines equals() but not hashCode(), and is used in hashing data structures. Think this functionally has no effect and no performance impact since it is just delegating to the superclass.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla marked this pull request as ready for review October 31, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant