added to OSN new handler for fetch a block of channel part 2 #5290
Conversation
| } | ||
|
|
||
| // swagger:operation GET /v1/participation/channels/{channelID} channels listChannel | ||
| // swagger:operation GET /participation/v1/channels/{channelID} channels listChannel |
There was a problem hiding this comment.
According to the code, everywhere orderer and osnadmin we use "/participation/v1/". And only in the swagger file the path is reversed "/v1/participation/". This option is not working. This means that no one has used the swagger file yet.
Of the two options, I chose to leave the one that is exactly being used, respectively, and fixed the other one.
There was a problem hiding this comment.
The description of // swagger:operation only helps the program generate the file swagger.json doesn't affect anything else.
The actual path pattern is defined below, and usually uses the constant URLBaseV1
There was a problem hiding this comment.
Putting the version number ahead is preferable. When you update to a newer version, it is easy to distinguish from the very beginning.
There was a problem hiding this comment.
Alas, this is inherited. I know it's better this way, but then we'll break backward compatibility. Because so far everything has worked when the version was in second place.
There was a problem hiding this comment.
Now there is a lot of code that already uses the version in the 2nd place.
For example: https://github.com/hyperledger/fabric-admin-sdk/blob/main/internal/osnadmin/join.go#L19
|
Why is the description empty? |
part 2 Signed-off-by: Fedor Partanskiy <[email protected]>
pfi79
force-pushed
the
add-osn-get-block2
branch
from
c8bdcba to
53c1b05
Compare
|
@C0rWin shall we cut a release on the weekend? |
Please wait for 2 pr. I need to finish the theme. |
Sure |
No description provided.