desktop/windowRules: fix matching on content prop#13275
Merged
vaxerski merged 1 commit intohyprwm:mainfrom Feb 16, 2026
Merged
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
vaxerski
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Match checker for content type is
RULE_MATCH_ENGINE_INT, but the switch was comparing input prop (int, as mentioned in wiki) to a string which doesn't work, so just use the content type enum directly instead. Fixes #12887.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
If you write
match:content gamein your rule or something similar, instead ofmatch:content 3, every window will be matched against. But this behaviour is consistent for all other rules too, not unique for content type, and generally there's no validation/errors thrown for putting strings where ints should be/vice versa.Probably doesn't matter since it clearly mentions what the allowed rule values are in the wiki, but thought I'd mention it.
Is it ready for merging, or does it need work?
Ready!