Skip to content

desktop/windowRules: fix matching on content prop#13275

Merged
vaxerski merged 1 commit intohyprwm:mainfrom
ssareta:fix-content-rule
Feb 16, 2026
Merged

desktop/windowRules: fix matching on content prop#13275
vaxerski merged 1 commit intohyprwm:mainfrom
ssareta:fix-content-rule

Conversation

@ssareta
Copy link
Contributor

@ssareta ssareta commented Feb 14, 2026

Describe your PR, what does it fix/add?

Match checker for content type is RULE_MATCH_ENGINE_INT, but the switch was comparing input prop (int, as mentioned in wiki) to a string which doesn't work, so just use the content type enum directly instead. Fixes #12887.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

If you write match:content game in your rule or something similar, instead of match:content 3, every window will be matched against. But this behaviour is consistent for all other rules too, not unique for content type, and generally there's no validation/errors thrown for putting strings where ints should be/vice versa.

Probably doesn't matter since it clearly mentions what the allowed rule values are in the wiki, but thought I'd mention it.

Is it ready for merging, or does it need work?

Ready!

@github-actions
Copy link

Hello and thank you for making a PR to Hyprland!

Please check the PR Guidelines and make sure your PR follows them.
It will make the entire review process faster. :)

If your code can be tested, please always add tests. See more here.

beep boop, I'm just a bot. A real human will review your PR soon.

@vaxerski vaxerski merged commit 17fc159 into hyprwm:main Feb 16, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants