pointermgr: damage only the surface size#13284
Open
gulafaran wants to merge 1 commit intohyprwm:mainfrom
Open
Conversation
CWaylandOutput returns a vector2d with -1, -1 set as a "no limit", passing that down into beginSimple and the renderer it hits pixman bug of invalid sizes and wrong rectangles gets created. causing bunch of *** BUG *** In pixman_region32_init_rect: Invalid rectangle passed just set the damage to the size we render the texture down below instead and we not only solve pixman issue but we dont overdamage either.
vaxerski
reviewed
Feb 16, 2026
| const auto& damageSize = state->monitor->m_output->cursorPlaneSize(); | ||
| g_pHyprOpenGL->beginSimple(state->monitor.lock(), {0, 0, damageSize.x, damageSize.y}, RBO); | ||
| auto damage = Vector2D{m_currentCursorImage.size / m_currentCursorImage.scale * state->monitor->m_scale}.round(); | ||
| g_pHyprOpenGL->beginSimple(state->monitor.lock(), {0, 0, damage.x, damage.y}, RBO); |
Member
There was a problem hiding this comment.
well no we still render the entire plane
Contributor
Author
There was a problem hiding this comment.
needs something done when CWaylandOutput then, just assume its a 256x256 then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CWaylandOutput returns a vector2d with -1, -1 set as a "no limit", passing that down into beginSimple and the renderer it hits pixman bug of invalid sizes and wrong rectangles gets created.
causing bunch of
*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
just set the damage to the size we render the texture down below instead and we not only solve pixman issue but we dont overdamage either.