fix(config): support * as wildcard monitor for default wallpapers #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add isWildcard() helper to treat both empty string and "*" as wildcards
when matching wallpaper settings to monitors.
This works around a limitation in hyprlang where listKeysForSpecialCategory()
skips entries with empty string keys (due to isStatic check in retrieveKeysForCat),
causing configs like:
wallpaper {
monitor =
path = /path/to/image.png
}
to be silently ignored. Users should now use "monitor = *" instead.
Member
|
yeah but the limitation got fixed, no? |
Contributor
Author
|
Correct, I actually raised this before the other fix PR, but thought I'd leave this here for consideration (or just reject) |
vaxerski
approved these changes
Jan 7, 2026
Member
vaxerski
left a comment
vaxerski
left a comment
There was a problem hiding this comment.
I dont mind really, no monitor will be called *
martijnboers
added a commit
to martijnboers/stylix
that referenced
this pull request
Jan 13, 2026
Added in hyprwm/hyprpaper#315 also adds mkDefault in order to allow users to override values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add isWildcard() helper to treat both empty string and "*" as wildcards when matching wallpaper settings to monitors.
This works around a limitation in hyprlang where listKeysForSpecialCategory() skips entries with empty string keys (due to isStatic check in retrieveKeysForCat), causing configs like:
to be silently ignored. Users should now use "monitor = *" instead.