fix: update registerRoutes to be compatible with Filament v4.8.0 - #1
Merged
Conversation
Filament v4.8.0 introduced "Configurable resources", which updated the Page::registerRoutes() signature to include an optional PageConfiguration parameter: registerRoutes(Panel $panel, ?PageConfiguration $configuration = null) ApiTokens::registerRoutes() was not updated to match, causing a PHP fatal error on autoload due to incompatible method signature inheritance. Added the missing optional `?PageConfiguration $configuration = null` parameter to restore compatibility with Filament v4.8.0+, and passed $configuration through to the internal static::routes() as well. Fixes: PHP Fatal error: Declaration of Filament\Jetstream\Pages\ApiTokens::registerRoutes(Filament\Panel $panel): void must be compatible with Filament\Pages\Page::registerRoutes(Filament\Panel $panel, ?Filament\Pages\PageConfiguration $configuration = null): void Ref: https://github.com/filamentphp/filament/releases/tag/v4.8.0 Ref: filamentphp/filament#19225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filament v4.8.0 introduced "Configurable resources", which updated the Page::registerRoutes() signature to include an optional PageConfiguration parameter:
registerRoutes(Panel $panel, ?PageConfiguration $configuration = null)ApiTokens::registerRoutes() was not updated to match, causing a PHP fatal error on autoload due to incompatible method signature inheritance.
?PageConfiguration $configuration = nullparameter to restore compatibility with Filament v4.8.0+, and passed $configuration through to the internal static::routes() as well.Fixes:
Ref: https://github.com/filamentphp/filament/releases/tag/v4.8.0
Ref: filamentphp/filament#19225