Skip to content

Conversation

@error414
Copy link
Contributor

@error414 error414 commented Jan 10, 2026

User description

Removed invertedCardDetection settings.

Ussage of setting has been removed by digitaentity in commit
3b2f87b "Refactor SDCARD; Separate generic code from SPI-specific code"

In next commit 986980c "Convert targets to new SDCARD defines"

the setting has been replaced by "#define"
#if defined(SDCARD_DETECT_INVERTED) return !result; #else return result; #endif


PR Type

Enhancement


Description

  • Remove unused invertedCardDetection setting from blackbox configuration

  • Setting was replaced by SDCARD_DETECT_INVERTED preprocessor define

  • Clean up struct definition, documentation, and settings configuration


Diagram Walkthrough

flowchart LR
  A["blackboxConfig_t struct"] -->|remove field| B["invertedCardDetection removed"]
  C["blackbox.c config"] -->|remove default| B
  D["settings.yaml"] -->|remove setting| B
  E["Settings.md docs"] -->|remove documentation| B
Loading

File Walkthrough

Relevant files
Enhancement
blackbox.h
Remove invertedCardDetection field from struct                     

src/main/blackbox/blackbox.h

  • Remove uint8_t invertedCardDetection field from blackboxConfig_t
    struct
  • Simplify configuration structure by eliminating unused member
+0/-1     
blackbox.c
Remove invertedCardDetection initialization                           

src/main/blackbox/blackbox.c

  • Remove .invertedCardDetection = BLACKBOX_INVERTED_CARD_DETECTION
    initialization from PG_RESET_TEMPLATE
  • Clean up default configuration values
+0/-1     
Configuration changes
settings.yaml
Remove sdcard_detect_inverted setting definition                 

src/main/fc/settings.yaml

  • Remove sdcard_detect_inverted setting definition
  • Remove description, default value, field mapping, and condition
  • Eliminate setting that was replaced by preprocessor define
+0/-6     
Documentation
Settings.md
Remove sdcard_detect_inverted documentation                           

docs/Settings.md

  • Remove sdcard_detect_inverted documentation section
  • Remove explanation about SD card detection behavior and hardware
    variants
+0/-10   

@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant