Blackbox - remove unused setting #11236
Open
+0
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Removed invertedCardDetection settings.
Ussage of setting has been removed by digitaentity in commit
3b2f87b "Refactor SDCARD; Separate generic code from SPI-specific code"
In next commit 986980c "Convert targets to new SDCARD defines"
the setting has been replaced by "#define"
#if defined(SDCARD_DETECT_INVERTED) return !result; #else return result; #endifPR Type
Enhancement
Description
Remove unused
invertedCardDetectionsetting from blackbox configurationSetting was replaced by
SDCARD_DETECT_INVERTEDpreprocessor defineClean up struct definition, documentation, and settings configuration
Diagram Walkthrough
File Walkthrough
blackbox.h
Remove invertedCardDetection field from structsrc/main/blackbox/blackbox.h
uint8_t invertedCardDetectionfield fromblackboxConfig_tstruct
blackbox.c
Remove invertedCardDetection initializationsrc/main/blackbox/blackbox.c
.invertedCardDetection = BLACKBOX_INVERTED_CARD_DETECTIONinitialization from
PG_RESET_TEMPLATEsettings.yaml
Remove sdcard_detect_inverted setting definitionsrc/main/fc/settings.yaml
sdcard_detect_invertedsetting definitionSettings.md
Remove sdcard_detect_inverted documentationdocs/Settings.md
sdcard_detect_inverteddocumentation sectionvariants