Skip to content

Conversation

@bdherouville
Copy link

@bdherouville bdherouville commented Jan 12, 2026

User description

Updated target.h as suggested by qodo-code-review[bot] on maintenance branch for having MSPOD on PA0 for OpenIPC cameras and ground stations.


PR Type

Enhancement


Description

  • Add OMNIBUSF4PRO_MPOSD target configuration with MPOSD on PA0

  • Configure UART4 on PA0 for OpenIPC camera support

  • Conditionally disable ADC_CHANNEL_3 and RSSI when MPOSD is enabled

  • Refactor OMNIBUSF4PRO_LEDSTRIPM5 definition structure


Diagram Walkthrough

flowchart LR
  A["OMNIBUSF4PRO_MPOSD<br/>Configuration"] -->|Enables| B["UART4 on PA0<br/>for OpenIPC"]
  A -->|Disables| C["ADC_CHANNEL_3<br/>and RSSI"]
  A -->|Inherits| D["OMNIBUSF4PRO<br/>with LED Strip M5"]
Loading

File Walkthrough

Relevant files
Enhancement
target.h
Add OMNIBUSF4PRO_MPOSD configuration with PA0 MPOSD support

src/main/target/OMNIBUSF4/target.h

  • Renamed OMNIBUSF4PRO_LEDSTRIPM5 ifdef to OMNIBUSF4PRO_MPOSD with
    updated documentation
  • Added conditional OMNIBUSF4PRO_LEDSTRIPM5 definition within the new
    OMNIBUSF4PRO_MPOSD block
  • Added UART4 configuration on PA0 when USE_MPOSD_ON_PA0 is defined
  • Protected ADC_CHANNEL_3_PIN assignment to avoid conflict with MPOSD on
    PA0
  • Made RSSI_ADC_CHANNEL conditional: set to ADC_CHN_NONE for
    OMNIBUSF4PRO_MPOSD, otherwise ADC_CHN_3
+17/-4   

Updated target.h as suggested by qodo-code-review[bot] on maintenance branch
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jan 12, 2026

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

bdherouville and others added 3 commits January 12, 2026 11:42
Co-authored-by: qodo-code-review[bot] <151058649+qodo-code-review[bot]@users.noreply.github.com>
Co-authored-by: qodo-code-review[bot] <151058649+qodo-code-review[bot]@users.noreply.github.com>
Use USE_MPOSD_ON_PA0 for rssi logc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant