[Point Cloud]: limit instantiation of new nodes during load of the parent node.#2710
Draft
ftoromanoff wants to merge 20 commits intoiTowns:masterfrom
Draft
[Point Cloud]: limit instantiation of new nodes during load of the parent node.#2710ftoromanoff wants to merge 20 commits intoiTowns:masterfrom
ftoromanoff wants to merge 20 commits intoiTowns:masterfrom
Conversation
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
2 times, most recently
from
8e7630d to
5df487d
Compare
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
2 times, most recently
from
aeb4133 to
1eda22e
Compare
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
from
1eda22e to
21ecee7
Compare
Contributor
|
@ftoromanoff can you explicit the purpose of this PR (why?) in the description please ? |
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
from
21ecee7 to
e571adb
Compare
…OT PUSH into MASTER
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
from
e571adb to
5a87b41
Compare
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
from
5a87b41 to
b7c74fd
Compare
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
10 times, most recently
from
7ecf09a to
a4a601d
Compare
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
2 times, most recently
from
130a68e to
20fcee0
Compare
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
from
20fcee0 to
e0f96a0
Compare
ftoromanoff
force-pushed
the
feat/loadChildrenOnly
branch
from
c8a8d4a to
cb2f1ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial aim was to limite the creation (and loading) of new node only when we will need them (meaning when we are loading there parent node) and not as it is currently done when the layer is instanciate (throught layer.root = new Node following by node.loadOctree).