feat(style): move style.point.model to its own category: 'model' by ftoromanoff · Pull Request #2808 · iTowns/itowns

ftoromanoff · 2026-07-01T08:37:53Z

Currently, to instanciate several object 3D at different position, the associated style is the style category 'point' with the parameter 'object'.
The use of extra parameter as 'orientation', 'size', 'scale' to cite a few is currently limited. That's the reason why I propose to add a new style category 'model' with it's own parameter. (As it's done for text and icon).

Shift the model.scale.set() to style.model.scale (to keep the origin size of the model)
add orientation of the model through 'up' and 'north' properties (as Vector3)

gchoqueux · 2026-08-04T10:48:11Z

+    const styleModel = style.model;
+    const count = geometries.length;
    const instancedMesh = new THREE.InstancedMesh(mesh.geometry, mesh.material, count);
-    let index = 0;
-    for (let i = 0; i < count * 3; i += 3) {
-        const mat = new THREE.Matrix4();
-        mat.setPosition(ptsIn[i], ptsIn[i + 1], ptsIn[i + 2]);
-        instancedMesh.setMatrixAt(index, mat);
-        index++;
+
+    for (let j = 0; j < count; j += 1) {
+        context.setGeometry(geometries[j]);
+        scale.set(1, 1, 1);
+        if (styleModel.size) {
+            scale.set(
+                styleModel.size.x / modelSize.x,
+                styleModel.size.y / modelSize.y,
+                styleModel.size.z / modelSize.z,
+            );
+        }
+
+        let headingRad = 0;
+        if (styleModel.heading) {
+            headingRad = styleModel.heading * THREE.MathUtils.DEG2RAD;
+        }
+        mat.makeRotationZ(-headingRad);
+        mat.setPosition(ptsIn[j * 3], ptsIn[j * 3 + 1], ptsIn[j * 3 + 2]);
+        mat.scale(scale.multiplyScalar(styleModel.scale));
+        instancedMesh.setMatrixAt(j, mat);


Could you use Vector3 methods to simplify your code

done
scale.set(1, 1, 1) => scale.setScalar(1)
scale.set(x1/V.x, y1/V.y, z1/V.z) => scale.divide(V)

gchoqueux · 2026-08-04T10:50:28Z

+                        model: {
+                            object: model,


could you rename var model to object to have model: { object,

gchoqueux · 2026-08-04T11:00:40Z

+    const modelObject = style.model.object;
+
+    // orientation of the model following up and north properties.
+    quaternion.setFromUnitVectors(style.model.up, zVect);


It's possible to use Object3D.up ?

I tried it to use with Object3D.lookAt(). But it has no direct impact to orient the object.

gchoqueux · 2026-08-04T11:09:55Z

+    const northWithRotation = style.model.north.applyQuaternion(quaternion.clone().conjugate());
+    const angletoNorth =  northWithRotation.angleTo(yVect);
+    quaternionY.setFromAxisAngle(yVect, angletoNorth);
+    quaternion.multiply(quaternionY);
+
+    modelObject.setRotationFromQuaternion(quaternion);


This part seems complex; we could first orient the Z-axis locally toward the north, and then calculate the quaternion needed to orient the Z-axis in global space.

As we will need to calculate the size of the model object in the world space (using the bbox) we need the model oriented in the global space.

Neptilo · 2026-08-13T14:57:14Z

+ * @property {object|Function} model.heading - The heading (or azimuth) to orient the model in degree.
+ * @property {object|Function} model.scale - The value to scale the model. (default value is 1).
+ * @property {object|Function} model.up - The vector pointing up. (default value is Vector3(0, 0, 1)).
+ * @property {object|Function} model.north - The vector pointing north. (default value is Vector3(0, 1, 0)).


Is this north vector supposed to be tangent to the ground, so orthogonal to up? What happens if it's not?

The user should be able to define a vector, that point toward the 'head' or the 'front' of the model. It's per defiition orthogonal to 'up'. Maybe we should better use 'head' or 'front' or an other name ?. 'north' is more the direction in the world referentiel where the head will be directed as for the meaning 'heading' which is the angle between the head and the north.

That makes sense. In that case, "front" sounds good. It matches the wording of most 3D modelling software. Then, the east vector in my code snippet in Feature2Mesh.js should be called right.
If the up and front vector are supposed to be orthogonal, I think we should either mention it in the doc, or check the input received by the function is valid.

I can't imagine a real case where we would have the front of a model and a up, not being orthognal...

Ps: I renamed using front and right, it sounds better indeed.

I agree that there are no such use cases, but it doesn't hurt to document the expected properties that the input values should verify. Or do a sanity check.

I did add it in the documentation for 'front'.

…rGeometry() and THREE.SphereGeometry()

ftoromanoff · 2026-08-27T12:49:29Z

I just did a rebase to the main branch.
I remark that in Feature2Mesh.js, you removed almost all the context setup, (now done with refreshCollectionContext()), from the featureToExtrudedPolygon().

ftoromanoff force-pushed the feat/modelStyle branch 2 times, most recently from af3c3a0 to c1ca507 Compare July 1, 2026 09:08

ftoromanoff changed the title ~~feat(style): move style.point.model to its own category model~~ feat(style): move style.point.model to its own category: 'model' Jul 1, 2026

gchoqueux reviewed Jul 1, 2026

View reviewed changes

ftoromanoff force-pushed the feat/modelStyle branch 2 times, most recently from 96261e2 to fe81a26 Compare July 7, 2026 13:16

ftoromanoff force-pushed the feat/modelStyle branch 5 times, most recently from ab49d98 to 1db5332 Compare July 28, 2026 12:12

ftoromanoff marked this pull request as ready for review July 28, 2026 12:24

ftoromanoff force-pushed the feat/modelStyle branch 10 times, most recently from ba7f2da to fc81a0b Compare July 30, 2026 09:58

ftoromanoff requested a review from Neptilo July 31, 2026 10:40

gchoqueux reviewed Aug 4, 2026

View reviewed changes

ftoromanoff force-pushed the feat/modelStyle branch 5 times, most recently from 99029ea to ebe3491 Compare August 5, 2026 15:21

Neptilo requested changes Aug 13, 2026

View reviewed changes

ftoromanoff force-pushed the feat/modelStyle branch 4 times, most recently from d2832f3 to 94744e8 Compare August 27, 2026 09:32

ftoromanoff added 5 commits August 27, 2026 12:02

fix(example): misc_instancing and realistic lightning

257b624

fix(example): misc_instancing -> use default values for THREE.Cylinde…

80a867e

…rGeometry() and THREE.SphereGeometry()

feat(style): move style.point.model to its own category model

d77b240

refacto(Feature2Mesh): use up and north vector for style.model

468c1ec

fix(review): Neptilo review

58136b6

ftoromanoff force-pushed the feat/modelStyle branch from 94744e8 to 58136b6 Compare August 27, 2026 12:46

Uh oh!

Conversation

ftoromanoff commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ftoromanoff Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ftoromanoff Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ftoromanoff commented Aug 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ftoromanoff commented Jul 1, 2026 •

edited

Loading

ftoromanoff Aug 5, 2026 •

edited

Loading

ftoromanoff Aug 24, 2026 •

edited

Loading