Fix PRAGMA quickCheck() reporting#1324
Open
MichaelSwigerAtBentley wants to merge 2 commits intomainfrom
Open
Conversation
MichaelSwigerAtBentley
requested review from
calebmshafer,
khanaffan,
pmconne and
rschili
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes QuickCheck reporting so PRAGMA integrity checks correctly return false when failures are detected, instead of always reporting success.
Changes:
- Track whether each integrity check reports an error and pass that status to the callback.
- Correct the callback’s check name for the
CheckMissingChildRowscase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itwinjs-core: iTwin/itwinjs-core#8958
Fixes an issue where calling PRAGMA integrity_check would always return true even if the check failed. This was caused due to a true boolean always being returned instead of what the check returned.
Unit tests to confirm this are added as a part of the iTwin-core PR.
Fixes: https://github.com/iTwin/itwinjs-backlog/issues/1847