feat: Add SQLite performance tuning configuration options #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `[sqlite]` configuration section with cache_size_mb, busy_timeout_ms, synchronous mode, and mmap_size options - Implement automatic per-shard calculation for cache and mmap settings with floor division - Update default synchronous mode to NORMAL for better safety in WAL mode - Increase migration cache to 1GB for better performance during shard migrations - Add comprehensive documentation in config.example.toml with tuning recommendations - Print SQLite configuration on server startup for visibility - Enable foreign_keys pragma for data integrity
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add max_connections config option for SQLite connection pool size (default: 10) - Update cache and mmap calculation to divide by (shards * connections) instead of just shards - Add helper methods for per-connection cache and mmap sizes - Update startup output to show per-connection resource allocation - Improve integer overflow safety with saturating arithmetic and clamping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sqlite]configuration section with cache_size_mb, busy_timeout_ms, synchronous mode, and mmap_size options