Improve on Split logic for single window#1843
Closed
mgabs wants to merge 7 commits intoianyh:developmentfrom
Closed
Improve on Split logic for single window#1843mgabs wants to merge 7 commits intoianyh:developmentfrom
mgabs wants to merge 7 commits intoianyh:developmentfrom
Conversation
- Injected window margin configuration into `FrameAssignment` and `Layout` classes to avoid singleton access in tight loops. - Optimized "smart window margins" calculation in `ScreenManager` to use managed window count instead of expensive system calls. - Refactored `ReflowOperation.perform(withWindow:)` to reduce code duplication. - Added unit tests for `ReflowOperation` margin logic. Made-with: Cursor
- Correctly inject window margin configuration into ResizeRules and FrameAssignment. - Ensure ScreenManager calculates margins based on managed window count and user preference. - Update all layouts to pass margin configuration to ResizeRules. - Fix concurrency warning in ReflowOperation. - Remove unused variable in BinarySpacePartitioningLayout. - Update tests to reflect changes. Made-with: Cursor
- Add 'test' lane to Fastlane to run tests without code signing. - Add 'local_release' lane for optimized local builds. - Update GitHub Actions workflow 'tests.yml' to use 'fastlane test'. - Ignore fastlane test output. Made-with: Cursor
• `Amethyst.xcodeproj/project.pbxproj`:
• Updated MARKETING_VERSION from 0.24.1 to 0.24.2.
• Incremented CURRENT_PROJECT_VERSION from 125 to 126.
Author
|
No AI was harmed in this project! |
Dropping release
- Added a check for accessibility permissions in `applicationDidBecomeActive` to handle cases where permissions are granted after launch or not detected correctly on initial launch. - Added `NSAccessibilityUsageDescription` to Info.plist to improve permission prompting on newer macOS versions. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes