feat(risingwave): support tumble and hop window agg#11970
feat(risingwave): support tumble and hop window agg#11970litaxc wants to merge 4 commits intoibis-project:mainfrom
Conversation
|
Can you add tests for this similar to Alternatively, it could also be an option to centralize the window tests in |
|
I added tests for the |
deepyaman
left a comment
There was a problem hiding this comment.
Looks good overall, very much aligned to the Flink implementation (which is great). @cpcloud / @gforsyth / @NickCrews could one of you kick off the CI workflow?
| t = alltypes | ||
| expr = ( | ||
| t.window_by(t.timestamp_col) | ||
| .hop(size=ibis.interval(days=10), slide=ibis.interval(days=10)) |
There was a problem hiding this comment.
Maybe should use a different slide so that it's not essentially a hopping window? :) I'm sure it works, but even reviewing at a glance I just noticed the results are the same.
There was a problem hiding this comment.
I tried using size=20 days, but I couldn't quite understand the resulting window_start/end produced by RisingWave. So I changed back to use the same size and slide to ensure I would't introduce wrong results.
Description of changes
Implement the visit_WindowAggregate function as it is done in Flink.
Issues closed
Resolves #11969