Repository navigation
fix(feeds): refresh corrected publication dates on existing posts - #183
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is scoped, preserves existing post identity, and comprehensively tests the stated edge cases.
0 open findings
What changed in this PR
Refreshes publication dates for existing feed posts without changing identity, ingestion metadata, or triggering new ActivityPub deliveries.
Changes:
- Adds batched, bot-scoped publication-date updates.
- Integrates refreshes into feed publishing.
- Adds database, publisher, RSS/Atom tests and operational documentation.
| File | Description |
|---|---|
src/lib/publisher.ts |
Refreshes dates before deduplicating entries. |
src/lib/db.ts |
Implements validated batched date updates. |
src/lib/__tests__/rss.test.ts |
Covers date precedence and timezone parsing. |
src/lib/__tests__/publisher.test.ts |
Verifies refresh integration. |
src/lib/__tests__/db.test.ts |
Covers update behavior and isolation. |
docs/operations.md |
Documents refresh semantics and limitations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Robbie Lyman’s feed now dates “Extend Lua with Zig 1” October 6, 2026, but robot.villas retains September 30, 2027 because existing GUIDs are skipped. Refresh valid feed-supplied publication dates in one batched update without reposting or changing IDs, grabbed times, titles, or hashtags. Missing/invalid dates cannot erase known dates.
Verified: 319 database-backed tests, lint/typecheck, production build, and feed validation passed. Added coverage for corrections, missing dates, bot isolation, deleted posts, duplicate GUIDs, and RSS/Atom date precedence and offsets.
Risks
Corrections require a feed response with a body; HTTP 304 cannot refresh dates. Already-delivered remote copies are not updated. No schema migration is needed.