Skip to content

appio: Mark intercepting functions as public such that they are properly linked when using the PAPI shared library #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Treece-Burgess merged 1 commit into from
Oct 31, 2025
Merged

appio: Mark intercepting functions as public such that they are properly linked when using the PAPI shared library #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/components/appio/appio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ static const struct appio_counters {
********************************************************************/

int __close(int fd);
int close(int fd) {
__attribute__ ((visibility ("default"))) int close(int fd) {
int retval;
SUBDBG("appio: intercepted close(%d)\n", fd);
retval = __close(fd);
Expand All @@ -185,7 +185,7 @@ int close(int fd) {
}

int __open(const char *pathname, int flags, mode_t mode);
int open(const char *pathname, int flags, mode_t mode) {
__attribute__ ((visibility ("default"))) int open(const char *pathname, int flags, mode_t mode) {
int retval;
SUBDBG("appio: intercepted open(%s,%d,%d)\n", pathname, flags, mode);
retval = __open(pathname,flags,mode);
Expand All @@ -200,7 +200,7 @@ int open(const char *pathname, int flags, mode_t mode) {
struct timeval zerotv; /* this has to be zero, so define it here */

int __select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, struct timeval *timeout);
int select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, struct timeval *timeout) {
__attribute__ ((visibility ("default"))) int select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, struct timeval *timeout) {
int retval;
SUBDBG("appio: intercepted select(%d,%p,%p,%p,%p)\n", nfds,readfds,writefds,exceptfds,timeout);
long long start_ts = PAPI_get_real_usec();
Expand All @@ -211,7 +211,7 @@ int select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, struc
}

off_t __lseek(int fd, off_t offset, int whence);
off_t lseek(int fd, off_t offset, int whence) {
__attribute__ ((visibility ("default"))) off_t lseek(int fd, off_t offset, int whence) {
off_t retval;
SUBDBG("appio: intercepted lseek(%d,%ld,%d)\n", fd, offset, whence);
long long start_ts = PAPI_get_real_usec();
Expand All @@ -226,7 +226,7 @@ off_t lseek(int fd, off_t offset, int whence) {

extern int errno;
ssize_t __read(int fd, void *buf, size_t count);
ssize_t read(int fd, void *buf, size_t count) {
__attribute__ ((visibility ("default"))) ssize_t read(int fd, void *buf, size_t count) {
int retval;
SUBDBG("appio: intercepted read(%d,%p,%lu)\n", fd, buf, (unsigned long)count);

Expand Down Expand Up @@ -276,7 +276,7 @@ ssize_t read(int fd, void *buf, size_t count) {
}

size_t _IO_fread(void *ptr, size_t size, size_t nmemb, FILE *stream);
size_t fread(void *ptr, size_t size, size_t nmemb, FILE *stream) {
__attribute__ ((visibility ("default"))) size_t fread(void *ptr, size_t size, size_t nmemb, FILE *stream) {
size_t retval;
SUBDBG("appio: intercepted fread(%p,%lu,%lu,%p)\n", ptr, (unsigned long) size, (unsigned long) nmemb, (void*) stream);
long long start_ts = PAPI_get_real_usec();
Expand All @@ -299,7 +299,7 @@ size_t fread(void *ptr, size_t size, size_t nmemb, FILE *stream) {
}

ssize_t __write(int fd, const void *buf, size_t count);
ssize_t write(int fd, const void *buf, size_t count) {
__attribute__ ((visibility ("default"))) ssize_t write(int fd, const void *buf, size_t count) {
int retval;
SUBDBG("appio: intercepted write(%d,%p,%lu)\n", fd, buf, (unsigned long)count);
struct stat st;
Expand Down Expand Up @@ -350,7 +350,7 @@ ssize_t write(int fd, const void *buf, size_t count) {
// The PIC test implies it's built for shared linkage
#ifdef PIC
static ssize_t (*__recv)(int sockfd, void *buf, size_t len, int flags) = NULL;
ssize_t recv(int sockfd, void *buf, size_t len, int flags) {
__attribute__ ((visibility ("default"))) ssize_t recv(int sockfd, void *buf, size_t len, int flags) {
int retval;
SUBDBG("appio: intercepted recv(%d,%p,%lu,%d)\n", sockfd, buf, (unsigned long)len, flags);
if (!__recv) __recv = dlsym(RTLD_NEXT, "recv");
Expand Down Expand Up @@ -388,7 +388,7 @@ ssize_t recv(int sockfd, void *buf, size_t len, int flags) {
#endif /* PIC */

size_t _IO_fwrite(const void *ptr, size_t size, size_t nmemb, FILE *stream);
size_t fwrite(const void *ptr, size_t size, size_t nmemb, FILE *stream) {
__attribute__ ((visibility ("default"))) size_t fwrite(const void *ptr, size_t size, size_t nmemb, FILE *stream) {
size_t retval;
SUBDBG("appio: intercepted fwrite(%p,%lu,%lu,%p)\n", ptr, (unsigned long) size, (unsigned long) nmemb, (void*) stream);
long long start_ts = PAPI_get_real_usec();
Expand Down