Skip to content

Feat: TBA sections added dialogue on Calendar #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vicksey wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Feat: TBA sections added dialogue on Calendar #1336

vicksey wants to merge 21 commits into from

Conversation

@vicksey
Copy link
Contributor

@vicksey vicksey commented Nov 15, 2025 •
edited
Loading

Summary

When a user adds a TBA section to their schedule, a collapsible dialogue is now added to the bottom right of their calendar.
Alternative to #1310 that's less blaring to the user.
image

When screenshotted:
image

Test Plan

  • Add/remove TBA time sections

Issues

  • Could argue that its going to block an event on Friday night but tbh no one has anything there anyways

Closes #1181

@alexespejo alexespejo self-requested a review November 17, 2025 23:44
alexespejo
alexespejo requested changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@alexespejo alexespejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool 😄

@vicksey
Copy link
Contributor Author

vicksey commented Nov 26, 2025

@alexespejo I resolved all your comments, lmk if theres anything else !

@vicksey vicksey requested a review from alexespejo November 26, 2025 23:42
alexespejo
alexespejo requested changes Nov 30, 2025
View reviewed changes
@vicksey vicksey requested a review from alexespejo December 1, 2025 00:29
KevinWu098
KevinWu098 requested changes Dec 3, 2025
View reviewed changes
@github-actions github-actions bot added the Stale label Jan 2, 2026
@github-actions github-actions bot removed the Stale label Jan 5, 2026
@vicksey
Copy link
Contributor Author

vicksey commented Jan 12, 2026

Main Updates:

  • Refactored to TbaCalendarCard to stay consistent to websoc
  • Screenshot auto opens card
  • Removed the finicky logic to save the card's collapse state (idt its necessary & idt many people will be collapsing it since its off on the side)
  • Fixed design

@vicksey vicksey changed the title Feat: Async courses added dialogue on Calendar Feat: TBA sections added dialogue on Calendar Jan 12, 2026
@vicksey vicksey deployed to staging-1336 January 15, 2026 23:13 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevinWu098 KevinWu098 KevinWu098 requested changes

@alexespejo alexespejo Awaiting requested review from alexespejo

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AA Calendar Should Indicate Async

4 participants

@vicksey @alexespejo @KevinWu098