About box #1377
About box #1377
Conversation
Choollol
left a comment
Choollol
left a comment
There was a problem hiding this comment.
Left some suggestions, mostly small things that you may or may not want to change.
There was a problem hiding this comment.
Maybe suffix the file names with "Button" to make it clearer what this component is during development. Same with the other components in this folder.
I'm not sure exactly what the conventions are in this project though, so if this is standard let me know!
There was a problem hiding this comment.
Could also consider suffixing the relevant components with "LinkButton" to make it really clear what they do.
| import { AboutBox } from '$components/RightPane/CoursePane/SearchForm/AboutBox'; | ||
| import FuzzySearch from '$components/RightPane/CoursePane/SearchForm/FuzzySearch'; | ||
| import { HelpBox } from '$components/RightPane/CoursePane/SearchForm/HelpBox'; | ||
| // import { HelpBox } from '$components/RightPane/CoursePane/SearchForm/HelpBox'; |
There was a problem hiding this comment.
Not sure exactly what conventions are, but maybe delete any commented-out code. Same for the other commented part in this file.
| setLocalStorageAboutBoxCollapseTime(Date.now().toString()); | ||
| }, []); | ||
|
|
||
| const handleClick = useCallback(() => { |
There was a problem hiding this comment.
Nitpick: Move toggleExpandAboutBox(); to the top of the function to make it more readable
|
|
||
| import { PROJECTS_LINK } from '$src/globals'; | ||
|
|
||
| export const ICSSCIcon = (props: SvgIconProps) => ( |
There was a problem hiding this comment.
Move into separate file maybe, it's used only here for now so not too big.
| return getLocalStoragePatchNotesKey() !== LATEST_PATCH_NOTES_UPDATE && !tourShouldRun(); | ||
| } | ||
|
|
||
| function dismissedRecently(dismissalTime: string | null) { |
There was a problem hiding this comment.
This function's body is used in a couple other places too, we should probably create a shared utility for calculating this. Also maybe add some info about the time unit in the variable name, maybe dismissalTimeDays or create an options object.
If that should be done separately from this PR, I can make an issue and take it on.
| import { useHelpMenuStore } from '$stores/HelpMenuStore'; | ||
| import { useThemeStore } from '$stores/SettingsStore'; | ||
|
|
||
| const images = [ |
There was a problem hiding this comment.
Nitpick: Could add some type safety to these, something like this:
interface ImageInfo {
src: string;
title: string;
alt: string;
}
const images: ImageInfo[] = ...| expanded={expandAboutBox} | ||
| onChange={handleClick} | ||
| sx={{ | ||
| padding: 1, |
There was a problem hiding this comment.
This padding is causing the elements to shift the tiniest amount after the accordion opens. It's barely noticeable, but wanted to let you know in case it's a problem.
Summary
About antalmanac scheduler
https://discord.com/channels/772739905981644850/1320360830251827272/1445938264925016205
Collapsible about box that replaces the help box in the right pane.
Test Plan
Issues
Closes #1386 partially