Standardize mobile breakpoint detection (Fix #930) #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change consolidates all mobile detection logic to use the standardized `useIsMobile()` hook,
which uses the Material-UI theme's 'sm' breakpoint (768px). Previously, the codebase had
inconsistent implementations with some components using 960px and others using 768px.
Changes:
- Removed old MOBILE_BREAKPOINT constant (960px) from globals.ts
- Updated useIsMobile hook with comprehensive documentation
- Converted all useMediaQuery calls with theme.breakpoints.down('sm') to use useIsMobile hook
- Standardized mobile detection in 11 component files
This resolves issue #9930 by establishing a single source of truth for mobile breakpoint detection.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR standardizes mobile detection across the application by consolidating all mobile breakpoint logic to use the
useIsMobile()hook, which uses the Material-UI theme's 'sm' breakpoint (768px).Problem
Previously, there were ~50 instances of "isMobile" across 14 files with inconsistent implementations:
MOBILE_BREAKPOINTconstant set to 960pxtheme.breakpoints.down('sm')which is 768pxSolution
MOBILE_BREAKPOINTconstant (960px) from globals.tsuseIsMobilehookuseIsMobile()hookuseMediaQueryanduseThemeimportsChanges Made
Updated 11 files:
CourseRenderPane.tsx- Recruitment banner positioningSectionTable.tsx- Table column widthsGpaCell.tsx- GPA popup displayEnrollmentHistoryPopup.tsx- Graph sizing (2 instances)CourseInfoButton.tsx- Button layoutEnrollmentColumnHeader.tsx- Tooltip displayHome.tsx- Desktop/Mobile layout switcherScheduleManagement.tsx- Tab navigation logicScheduleManagementTab.tsx- Tab positioninguseIsMobile.tsx- Added documentationglobals.ts- Removed old constantTest Plan
Fixes
Closes #930