[ cleanup ] Refactor equality functions using maybeEq
#3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spcfox
changed the title
maybeEq
buzden
requested changes
Dec 11, 2025
Collaborator
buzden
left a comment
buzden
left a comment
There was a problem hiding this comment.
We've had a phone discussion, and I've named several moments I'd like to be changed, otherwise I think this change is good
spcfox
force-pushed
the
maybe-eq
branch
4 times, most recently
from
ece902e to
daac622
Compare
buzden
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added function to work with
Maybe (_ = _)and rewrote parts of the compiler code to use them.Self-check
CONTRIBUTING.mdand I've updated
CONTRIBUTORS.mdwith my name.implementation, I have updated
CHANGELOG_NEXT.md