Open
Conversation
Contributor
|
Thanks for the PR. I'm going to put it on hold for now because I think this is fixed in a branch I am working on, but I will test it. |
Contributor
Author
|
Sounds good, feel free to close if it's already fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, got another
NullPointerExceptionfix for you. A while back my coworker noticed the motif finder had stopped working (we're both still living onmainIGV, so I'm unsure if this ever made it into a release). Running the motif finder produces a null pointer exception and a stack trace:The problem seems to be that when adding the result tracks it uses
addTracks(), which uses.getResourceLocator()on each track to figure out where to put it, andMotifTrackdoesn't implement that function or pass any kind of resource locator to theFeatureTracksuperclass constructor.This commit fixes the NPE by adding the motif tracks one by one with
addTrackand explicitly telling them to go to the annotation panel. Another way to fix it might be to giveMotifTracks a resource locator, either by overridinggetResourceLocatoror by passing along some kind ofResourceLocatorin the constructor instead ofnull. I'm happy to take a crack at doing either of those instead if the current solution is too much of a hack (though I'm still a little fuzzy on what exactly aResourceLocatoris).Thanks!