Refine documentation for clarity and consistency #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AminMemariani
commented
Dec 8, 2025
AminMemariani
commented
- Improved grammar and clarity in CONTRIBUTING.md, README.md, and various documentation files.
- Standardized phrasing for properties in chart data classes across documentation.
- Enhanced descriptions for touch handling and tooltip functionalities in scatter, pie, and radar charts.
- Corrected minor typographical errors and formatting issues throughout the documentation.
- Improved grammar and clarity in CONTRIBUTING.md, README.md, and various documentation files. - Standardized phrasing for properties in chart data classes across documentation. - Enhanced descriptions for touch handling and tooltip functionalities in scatter, pie, and radar charts. - Corrected minor typographical errors and formatting issues throughout the documentation.
Owner
|
Thank you, it looks good to me. So please update your branch, then we can merge it! |
# Conflicts: # README.md # repo_files/documentations/index.md
- Add pump() calls between gesture movements for better timing - Add extra pump() calls after scaling to ensure chartVirtualRect is updated - Add null checks before assertions to make tests more robust - These changes should help tests pass reliably in CI environments
- Replace tester.dragFrom() with startGesture/moveTo/up pattern - This approach works better with CustomInteractiveViewer's GestureDetector - Add null checks after panning to ensure chartVirtualRect is updated - Should fix CI test failures for panning tests
- Verify that scaling actually occurred before attempting to pan - Wait for chartVirtualRect to be updated with proper size - Add attempt counter to prevent infinite loops in CI - This ensures tests wait for scaling to complete before panning
- Add unique key to ColoredBox widgets used in panning tests - Replace find.byType(ColoredBox) with find.byKey(chartColoredBoxKey) - Fixes CI error: 'Found 2 widgets with type ColoredBox' ambiguity - Ensures tests can uniquely identify the chart widget
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2038 +/- ##
==========================================
+ Coverage 92.49% 92.55% +0.05%
==========================================
Files 50 50
Lines 3731 3760 +29
==========================================
+ Hits 3451 3480 +29
Misses 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
You are welcome. Although the branch was updated, there were pipeline constraints that were blocking my commits, so I had to fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.