use protoc with presence #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-cube
force-pushed
the
simon/protoc-with-presence-2025-10-30
branch
from
04c04e4 to
4183eeb
Compare
c-cube
force-pushed
the
simon/protoc-with-presence-2025-10-30
branch
from
9ea91c4 to
7ab0b0c
Compare
c-cube
force-pushed
the
simon/protoc-with-presence-2025-10-30
branch
from
1f823d4 to
f1ac22e
Compare
ajbt200128
reviewed
Nov 21, 2025
| - run: | | ||
| opam pin ocaml-protoc 3.0.1 -y -n | ||
| opam pin pbrt 3.0.1 -y -n | ||
| opam pin https://github.com/mransan/ocaml-protoc.git#5510694deffde13283742b8ad116fab61b65dfbc -y -n |
Contributor
There was a problem hiding this comment.
fyi a nice way to do this even for testing is using a pin-depends field in an *.opam.template file:
https://github.com/semgrep/semgrep/blob/develop/semgrep.opam.template#L17-L20
this gets picked up picked up by dune when it generates the opam file. Additionally, this will also get picked up by nix so you don't have to make the change to flake.nix you have
Contributor
There was a problem hiding this comment.
Note that currently this opam package fails to install w/out this change
Contributor
|
Finally getting around to trying this in semgrep, will report back in a week or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be more compact on the wire, because presence tracking lets us know which fields were not set explicitly so we can avoid writing them entirely. It's also more compliant with other implementations of protobuf.