Skip to content

Change RNG to PCG64#688

Open
mnwright wants to merge 8 commits intomasterfrom
pcg_rng
Open

Change RNG to PCG64#688
mnwright wants to merge 8 commits intomasterfrom
pcg_rng

Conversation

@mnwright
Copy link
Member

As noted in #414, another random number generator (RNG) might be better than std::mt19937_64. Here, we switch to PCG.

TODOs:

  • Check whether this is faster (or slower)
  • Check reproducibility: Looking at the tests on Github actions, this won't fix the different results on Mac (Results are different between on Mac and on Windows #533).
  • Double check license issue. I think, including it as such is fine.
  • Are there any other side effects?

@waynelapierre
Copy link

Philox could be a better choice than PCG, and it has been voted into C++ 26. Is it possible to use Philox with a reference implementation now and transition to the std in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants