Feature/barista on stage by kejsibushi20 · Pull Request #1809 · impresso/impresso-frontend

kejsibushi20 · 2025-10-28T17:26:04Z

JSON structure + apply filters button

Refactored filter extraction logic in barista.ts by introducing getSearchFilters and updating getSearchFiltersAsBase64 to use it. Improved BaristaModal to allow editing and applying filters interactively, added SearchPills, and enhanced the results display. Simplified FilterMonitor entity suggester button layout for better UI consistency.

Copilot

Pull Request Overview

This PR refactors the Barista chat interface to use a modal-based UI instead of a floating popup, extracts filter parsing logic into a reusable function, and modernizes styling with Bootstrap utilities.

Key changes:

Introduced getSearchFilters() function to extract and return raw filter arrays from Barista responses
Created new BaristaModal.vue component using Composition API for displaying chat and filter results side-by-side
Refactored styling to use Bootstrap utilities and CSS custom properties instead of custom CSS

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/services/types/barista.ts	Exported previously internal interfaces and added `getSearchFilters()` helper function for extracting raw filters
src/components/barista/BaristaModal.vue	New modal component implementing chat interface with filter preview/application using Composition API
src/components/barista/BaristaChatPanel.vue	Updated styling to use Bootstrap utilities and removed custom CSS for chat input
src/components/barista/BaristaChat.vue	Refactored to emit stringified filters and display filter confirmation messages
src/components/barista/BaristaButton.vue	Replaced floating popup with `BaristaModal` component
src/components/modules/FilterMonitor.vue	Simplified button layout and added missing translation key

Copilot · 2025-10-29T14:48:49Z

src/services/types/barista.ts

+  // const filtersToolCalls =
+  //   kwargs.tool_calls?.filter?.(
+  //     tool_call => tool_call.type === 'function' && tool_call.function.name === 'Filters'
+  //   ) ?? []
+
+  // if (filtersToolCalls.length > 0) {
+  //   try {
+  //     const searchFilters = getSearchFilters(JSON.parse(filtersToolCalls[0].function.arguments))const serializedFilters = toSerializedFilters
+  //     const serializedFilters = toSerializedFilters(searchFilters['filters'])
+  //     return serializedFilters
+  //   } catch (error) {
+  //     console.error('Error parsing search filters:', error)
+  //     return undefined
+  //   }
+  // }
+  // return undefined


Remove commented-out code from lines 68-83. This appears to be old implementation that was replaced by the new logic.

Suggested change

// const filtersToolCalls =

// kwargs.tool_calls?.filter?.(

// tool_call => tool_call.type === 'function' && tool_call.function.name === 'Filters'

// ) ?? []

// if (filtersToolCalls.length > 0) {

// try {

// const searchFilters = getSearchFilters(JSON.parse(filtersToolCalls[0].function.arguments))const serializedFilters = toSerializedFilters

// const serializedFilters = toSerializedFilters(searchFilters['filters'])

// return serializedFilters

// } catch (error) {

// console.error('Error parsing search filters:', error)

// return undefined

// }

// }

// return undefined

Copilot · 2025-10-29T14:48:49Z

src/services/types/barista.ts

+
+  // if (filtersToolCalls.length > 0) {
+  //   try {
+  //     const searchFilters = getSearchFilters(JSON.parse(filtersToolCalls[0].function.arguments))const serializedFilters = toSerializedFilters


Line 75 contains malformed commented code with two statements concatenated on the same line without proper separation. If this code were uncommented, it would cause a syntax error.

Suggested change

// const searchFilters = getSearchFilters(JSON.parse(filtersToolCalls[0].function.arguments))const serializedFilters = toSerializedFilters

// const searchFilters = getSearchFilters(JSON.parse(filtersToolCalls[0].function.arguments))

Copilot · 2025-10-29T14:48:50Z

src/services/types/barista.ts

 >

-export const getSearchFiltersAsBase64 = (kwargs: AdditionalKwargs): string | undefined => {
+export const getSearchFilters = (kwargs: AdditionalKwargs): any[] => {


Return type any[] is too generic. Consider defining a specific interface for filter objects to improve type safety and make the API contract clearer.

Copilot · 2025-10-29T14:48:50Z

src/components/barista/BaristaModal.vue

+
+<script setup lang="ts">
+import { computed, ref, watch } from 'vue'
+import { getSearchFilters, getSearchFiltersAsBase64 } from '@/services/types/barista'


getSearchFiltersAsBase64 is imported but never used in this component. Remove the unused import.

Suggested change

import { getSearchFilters, getSearchFiltersAsBase64 } from '@/services/types/barista'

import { getSearchFilters } from '@/services/types/barista'

Copilot · 2025-10-29T14:48:51Z

src/components/barista/BaristaModal.vue

+  }
+})
+const searchFilters = ref([])
+const handleFiltersChanged = (newFilters: any) => {


Parameter type any should be replaced with a more specific type. Consider defining an interface for filter objects or using the return type from getSearchFilters().

Suggested change

const handleFiltersChanged = (newFilters: any) => {

const handleFiltersChanged = (newFilters: ReturnType<typeof getSearchFilters>) => {

Copilot · 2025-10-29T14:48:51Z

src/components/barista/BaristaButton.vue


 const isChatOpen = ref(false)
 const chatPopup = ref<HTMLElement | null>(null)
+const showModal = ref(true)


The variable showModal is defined but never used in the component. Consider removing it.

Suggested change

const showModal = ref(true)

Copilot · 2025-10-29T14:48:51Z

src/components/barista/BaristaButton.vue

+// const handleSearch = (searchFilters: string) => {
+//   // Emit the search event so parent components can listen
+//   emit('search', searchFilters)
+// }


Remove commented-out handleSearch function. It has been replaced by handleApplyFilters.

Suggested change

// const handleSearch = (searchFilters: string) => {

// // Emit the search event so parent components can listen

// emit('search', searchFilters)

// }

Copilot · 2025-10-29T14:48:52Z

src/components/barista/BaristaChat.vue

 }

-// Handler for sending messages
+//  Handles user input + Barista response


Comment has inconsistent spacing. Should be // Handles user input + Barista response with a space after //.

Suggested change

// Handles user input + Barista response

// Handles user input + Barista response

…o/impresso-frontend into feature/barista-on-stage

Adds a 'filters' prop to BaristaButton and passes filtersWithItems from Search.vue. Improves BaristaChatPanel input styling, adds focus on mount, and adjusts padding for better user experience.

…o/impresso-frontend into feature/barista-on-stage

danieleguido · 2026-01-26T19:43:10Z

see develop branch

danieleguido and others added 5 commits October 17, 2025 11:03

use Modal for Barista

f89bc9e

add BaristaChat

cb6ada4

use Modal for Barista

9cf8ad6

add BaristaChat

b20d74c

json filter displayed

b2b9c4f

danieleguido force-pushed the feature/barista-on-stage branch from a6a3fd2 to b2b9c4f Compare October 29, 2025 12:48

danieleguido added 2 commits October 29, 2025 14:05

reduce redundant styles and clean Barista Modal

93ac5c6

danieleguido requested a review from Copilot October 29, 2025 14:45

Copilot AI reviewed Oct 29, 2025

View reviewed changes

danieleguido and others added 9 commits October 30, 2025 12:32

improve style

666749b

Merge branch 'develop' into feature/barista-on-stage

f1e7396

Merge branch 'feature/barista-on-stage' of https://github.com/impress…

a930203

…o/impresso-frontend into feature/barista-on-stage

Update BaristaModal.vue

80a4d75

Fixed dublication of user input prompt and centered barista title

cc08815

Enhance Barista chat input and button props

4049c8f

Adds a 'filters' prop to BaristaButton and passes filtersWithItems from Search.vue. Improves BaristaChatPanel input styling, adds focus on mount, and adjusts padding for better user experience.

Merge branch 'develop' into feature/barista-on-stage

135504d

adding user primary filter into barista chatbot

3a1b68b

Merge branch 'feature/barista-on-stage' of https://github.com/impress…

856c7e7

…o/impresso-frontend into feature/barista-on-stage

danieleguido closed this Jan 26, 2026

danieleguido deleted the feature/barista-on-stage branch January 26, 2026 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/barista on stage#1809

Feature/barista on stage#1809
kejsibushi20 wants to merge 16 commits intodevelopfrom
feature/barista-on-stage

kejsibushi20 commented Oct 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

danieleguido commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// const searchFilters = getSearchFilters(JSON.parse(filtersToolCalls[0].function.arguments))const serializedFilters = toSerializedFilters
	// const searchFilters = getSearchFilters(JSON.parse(filtersToolCalls[0].function.arguments))

	import { getSearchFilters, getSearchFiltersAsBase64 } from '@/services/types/barista'
	import { getSearchFilters } from '@/services/types/barista'

	const handleFiltersChanged = (newFilters: any) => {
	const handleFiltersChanged = (newFilters: ReturnType<typeof getSearchFilters>) => {

	// Handles user input + Barista response
	// Handles user input + Barista response

Conversation

kejsibushi20 commented Oct 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

danieleguido commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants