Support for .NET Standard 2.0 / .NET 4.6.1 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for .NET Standard 2.0 (in all the core libraries) and .NET 4.6.1 (in the OMS and test projects). Summary of changes: - Update all projects to [SDK style][1]; set GenerateAssemblyInfo to false to [avoid having to touch existing AssemblyInfo files][2] - Use <PackageReference> instead of packages.config - Update .sln file to remove unnecessary build targets (assume AnyCPU) - Upgrade to newest NUnit - Modify path prefix in OrcaMDF.RawCore.Tests.BaseFixture - Move TestHelper out of core framework and include it as a linked file in all the test projects (this is needed because the code used here is [not compatible with .NET Standard][3]) [1]: https://docs.microsoft.com/en-us/dotnet/core/tools/csproj [2]: dotnet/runtime#26290 [3]: https://stackoverflow.com/questions/42138418/equivalent-to-assemblyinfo-in-dotnet-core-csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for .NET Standard 2.0 (in all the core libraries) and
.NET 4.6.1 (in the OMS and test projects).
Summary of changes:
to avoid having to touch existing AssemblyInfo files
all the test projects (this is needed because the code used here is
not compatible with .NET Standard)