Merged
Conversation
Closed
naomitzhao
previously requested changes
Mar 18, 2025
Collaborator
naomitzhao
left a comment
There was a problem hiding this comment.
While this technically works for the mixins we have defined, note that the layout has unexpected behavior in between the breakpoints. For example, between tablet and phone, the edges of the cards start going off the screen.
Instead of using mixins to statically define widths, can you create flexible layouts? Here's how you'd implement that at a high level:
- Notice for the mobile design, the entire page has the same width padding (16px on each side). You can give the .page class a mixin for mobile that applies 16px width padding for the entire page.
- For every other component, have it stretch to take up the entire width. Then when the screen size changes, the width of the component will change dynamically and take up the entire width it's allowed within the padding. This will happen automatically if you use a column flexbox and
align-items: stretch;for the page.
Let me know if you have any questions or need help getting this done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.