Skip to content

fix update weights from disk in FSDP engine #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
+6 −3
Merged

fix update weights from disk in FSDP engine #443

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
001c26f
fix update weight disk in fsdp engine
garrett4wade Oct 13, 2025
14c3202
Update areal/engine/fsdp_engine.py
garrett4wade Oct 13, 2025
1784145
.
garrett4wade Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions areal/engine/fsdp_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,6 @@ def _update_weights_from_disk(self, meta: WeightUpdateMeta):
# dist.barrier() are called when _save_model_to_hf finished

if dist.get_rank() == 0:
fut.result()

update_name = names.update_weights_from_disk(
self.config.experiment_name,
self.config.trial_name,
Expand All @@ -401,6 +399,8 @@ def _update_weights_from_disk(self, meta: WeightUpdateMeta):
update_name, str(datetime.now().timestamp()), keepalive_ttl=120
)

fut.result()

dist.barrier(device_ids=[self.device.index])
current_platform.synchronize()

Expand All @@ -420,7 +420,10 @@ def connect_engine(self, engine: InferenceEngine, meta: WeightUpdateMeta):
)
self.rollout_engine = engine

if not self.weight_update_group_initialized:
if (
meta.type == current_platform.communication_backend
and not self.weight_update_group_initialized
):
self._init_weight_update_from_distributed(meta)
self.weight_update_group_initialized = True

Expand Down
Loading