feat: compose words using combine symbols#58
Draft
klown wants to merge 14 commits intoinclusive-design:mainfrom
Draft
feat: compose words using combine symbols#58klown wants to merge 14 commits intoinclusive-design:mainfrom
klown wants to merge 14 commits intoinclusive-design:mainfrom
Conversation
Note that this is the first commit and is nowhere near working. The intent is to add or remove symbols with a single "/" between them to make a new single bliss-word.
Note: This improves the code in the previous commmti, but this still needs a lot of work. For example, there are type errors and relevant tests need to be updated for the changes here.
- move most of `ContentBmwEncoding.ts` code to `ContentEncodingInputField.ts`. - use `ariaControls` property of some of the `CommandXxx` components to determine which contents signal the command modifies, - add `contentSignalMap` global object that uses the id on the content encoding component to select the associated content signal.
- remove extraneous imports - fix content signal assignment in `ActionIndicatorCell` - improve toggle styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run lintwithout errorsnpm testwithout errorsnpm run buildwithout errorsnpm run devwithout errorsDescription
This is an attempt at providing the means for users for combine symbols from their palettes to compose Bliss-words, optioinally mark them with the combine marker, and finally transfer them to the existent symbol input field.
Steps to test
Note: once the composed symbol has been added to the main input area, it is treated as a unit, and can no longer be edited.
Additional information
The
feat/compose-wordsbranch is based on themainbranch in theinclusive-design/adaptive-palette repository.The is very much a work in progress. The UI needs work and there are several new Preact components that require unit tests. These include:
ContentComposeWordsEntry: similar to the existingContentBmwEncodingcomponent.ToggleIsComposingWords: switch to allow user to change between normal operation and composing words mode.ToggleMakeCombination: button for adding/removing the combine marker to the composed word.CommandAddCompostion: button to transfer the composed word to the main input area and set the compose switch to "off".