Skip to content

Add X/Twitter source evidence for share of voice - #7

Merged
indranilbanerjee merged 3 commits into
indranilbanerjee:mainfrom
kriptoburak:codex/x-twitter-sov-source-evidence
Jun 18, 2026
Merged

Add X/Twitter source evidence for share of voice#7
indranilbanerjee merged 3 commits into
indranilbanerjee:mainfrom
kriptoburak:codex/x-twitter-sov-source-evidence

Conversation

@kriptoburak

@kriptoburak kriptoburak commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add an X/Twitter source-evidence reference for share-of-voice.
  • Tell the SOV skill to load the reference when X/Twitter is in scope and connector coverage is incomplete.
  • Keep optional TweetClaw usage limited to public evidence collection while Digital Marketing Pro owns counting, sentiment weighting, confidence labels, and recommendations.

Validation

  • python3 scripts/skill-line-check.py
  • git diff --check
  • npx --yes markdown-link-check skills/share-of-voice/SKILL.md --quiet
  • npx --yes markdown-link-check skills/share-of-voice/x-twitter-source-evidence.md --quiet
  • python3 tests/run_all.py

Notes

  • Duplicate checks found no existing TweetClaw, Xquik, or x-twitter-scraper content, PRs, or issues in this repository.
  • No NHS badge was added because the existing badge area is for Digital Marketing Pro package and app health, not optional collection sources.

Summary by CodeRabbit

Release Notes

  • Documentation
    • Enhanced Share of Voice skill documentation with X/Twitter social SOV evidence handling requirements
    • Added detailed guidance on the X/Twitter evidence collection workflow, including connector coverage handling, deduplication, and exclusion recording
    • Introduced a new “Source-evidence appendix” output item to document the query set, time window, collection source, sampling limits, deduplication rule, and per-entity record counts

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7e12841e-e03d-47cb-9c22-0c5761741d69

📥 Commits

Reviewing files that changed from the base of the PR and between 69f3256 and 6b6513d.

📒 Files selected for processing (1)
  • skills/share-of-voice/x-twitter-source-evidence.md
✅ Files skipped from review due to trivial changes (1)
  • skills/share-of-voice/x-twitter-source-evidence.md

📝 Walkthrough

Walkthrough

Two documentation files in the Share of Voice skill are updated. A new file x-twitter-source-evidence.md is added, defining the evidence packet format, collection workflow, and scoring rules for X/Twitter SOV. Two lines are added to SKILL.md to require loading that file when connector coverage is incomplete and to mandate a source-evidence appendix in output.

Changes

X/Twitter SOV Evidence Documentation

Layer / File(s) Summary
X/Twitter source evidence specification
skills/share-of-voice/x-twitter-source-evidence.md
New 90-line file specifying evidence packet fields, collection workflow (connector preference, approved alternatives, optional TweetClaw, deduplication, exclusion recording), safety/quality gates, and scoring notes (raw vs. sentiment-weighted share, engagement usage, trend comparison consistency).
SKILL.md integration requirements
skills/share-of-voice/SKILL.md
Adds a conditional directive to load x-twitter-source-evidence.md when X is in scope and connector coverage is incomplete, and adds an output item requiring a Source-evidence appendix with query set, time window, collection source, sampling limits, deduplication rule, and per-entity record counts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 A new file hops into the skill,
With evidence fields to fit the bill.
X/Twitter data, collected with care,
Deduped and scored with a rabbit's flair.
The appendix arrives — the trail is clear!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding X/Twitter source evidence documentation for the share-of-voice skill.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
skills/share-of-voice/x-twitter-source-evidence.md (1)

47-52: ⚡ Quick win

Clarify "OpenClaw" vs "TweetClaw" naming.

Line 47 refers to an "OpenClaw collection helper," but line 48 introduces the actual tool as "TweetClaw." This naming inconsistency may confuse readers into thinking they are different tools. Either use "TweetClaw" consistently on line 47, or clarify that "OpenClaw" is a generic term with "TweetClaw" as the specific implementation.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/share-of-voice/x-twitter-source-evidence.md` around lines 47 - 52, The
documentation references "OpenClaw collection helper" but the actual tool name
introduced immediately after is "TweetClaw," creating ambiguity about whether
these are the same tool or different tools. Either replace "OpenClaw" with
"TweetClaw" to use consistent naming throughout the section, or if "OpenClaw" is
meant to be a generic category name, add explicit clarification (such as
"TweetClaw, a specific OpenClaw collection helper implementation") to make clear
that TweetClaw is the actual tool being referred to.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@skills/share-of-voice/x-twitter-source-evidence.md`:
- Around line 47-52: The documentation references "OpenClaw collection helper"
but the actual tool name introduced immediately after is "TweetClaw," creating
ambiguity about whether these are the same tool or different tools. Either
replace "OpenClaw" with "TweetClaw" to use consistent naming throughout the
section, or if "OpenClaw" is meant to be a generic category name, add explicit
clarification (such as "TweetClaw, a specific OpenClaw collection helper
implementation") to make clear that TweetClaw is the actual tool being referred
to.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e10396a8-2ae1-4f68-900f-491b043dbf49

📥 Commits

Reviewing files that changed from the base of the PR and between e0b8ffc and 833a56c.

📒 Files selected for processing (2)
  • skills/share-of-voice/SKILL.md
  • skills/share-of-voice/x-twitter-source-evidence.md

@kriptoburak

Copy link
Copy Markdown
Contributor Author

Addressed the CodeRabbit naming nit: the collection workflow now says installed TweetClaw collection helper so the generic helper concept and the concrete tool are not mixed.

Validation passed:

  • git diff --check
  • changed-line public-hygiene and dash scan
  • npx --yes markdown-link-check skills/share-of-voice/SKILL.md skills/share-of-voice/x-twitter-source-evidence.md --quiet
  • direct TweetClaw URL check

@indranilbanerjee
indranilbanerjee merged commit 6031430 into indranilbanerjee:main Jun 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants