Fixed compiler warnings, simplified json override classes#101
Open
horfius wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up all the warnings. Some of the annoying ones are the nullable types which are informative but do cause warnings in #nullable false setups. I want devs to notice warnings when they pop up and not be drowned in existing ones.
Added x64 build configuration since some of the dlls were built for x64 and, while compatible with x32, it may be a good idea to fully build for x64 since we use so much memory anyways.
The json stuff obviously changes how we do things a bit. I could revert some of it, but having an id parameter instead of named map entries makes the structure more consistent.