Open
Conversation
Contributor
Author
|
@yingfeng Would love to hear your opinion on this PR. Thanks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13802 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 10 10
Lines 702 702
Branches 112 112
=======================================
Hits 679 679
Misses 5 5
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Would appreciate your feedback @Magicbook1108 @yingfeng :) |
Contributor
Author
|
Could you please give me opinion, @Magicbook1108 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR fixes WebDAV sync behavior for unsupported file types (#13795).
Previously, the WebDAV connector selected files primarily by modified time (and size threshold) and could still pass unsupported extensions into the download/document-generation path. This caused unnecessary processing and inconsistent behavior compared with connectors that validate file type earlier.
This change adds extension validation in two places:
It also wires
allow_imagesinto the WebDAV sync path so image extension handling follows connector policy.Scope is intentionally limited to WebDAV for a focused bug-fix PR.
Type of change
How was this tested?
.pdf,.txt,.md.exe,.bin,.datallow_imagessetting.Fixes: #13795