WIP: Convert app state to MobX-State-Tree #1380
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same way and it's getting loaded twice
Some packages require you add them to the whiteListedModules to work.
| @@ -9,7 +9,7 @@ export const ConnectionModel = t | |||
|
|
|||
| platform: t.enumeration(["ios", "android", "browser"] as const), | |||
| name: "", | |||
| platformVersion: "", | |||
| platformVersion: t.optional(t.union(t.number, t.string), ""), | |||
There was a problem hiding this comment.
@jamonholmgren - platformVersion is coming back as a number on Android, and a string on iOS. This handles both and defaults to an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in-progress moving reactotron-app to MST.