Skip to content

Conversation

finalquest
Copy link

@finalquest finalquest commented Apr 20, 2024

Please verify the following:

  • [ x] yarn build-and-test:local passes
  • [ x] I have added tests for any new features, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

I made a new network tab to group the api.responses messages.
Made a custom command to clear all the commands that are/not are api.
Removed the api filter from the Timeline modal

Next Steps

This changes only moved the rendered cell to another list.
I think that the command list should be splitted in commands and networkCommands.
The current solution works over the full command list.
Maybe we should make a right sidebar with all the header/request/response. Something like Flipper have

@GrinZero
Copy link

Hello 👋 Do you have a preview image of the effect

@finalquest
Copy link
Author

Hello 👋 Do you have a preview image of the effect

Hey. Sorry for the late response. I didn't saw the notification

Screenshot 2024-08-22 at 3 32 32 PM

@jzaefferer
Copy link

That looks great! Makes sense to give network requests its own tab and a separate panel for details.

@jzaefferer
Copy link

Looks like this is a duplicate of #1426 though.

@jamonholmgren
Copy link
Member

I do like the idea here, @finalquest, but since it looks like you're pulling in #1426 and building on that, we should leave their commits in to credit them for the work they've done.

Regardless, I'm not sure that I'll accept this as-is. Will do some thinking about this. I think it's a good idea, but the implementation here might need some more thought.

@longb1997
Copy link

longb1997 commented Jun 19, 2025

This is really good idea, please take a look

@jamonholmgren
Copy link
Member

I do think it's a good idea. I'm focused on a rewrite of Reactotron right now, but I'll keep this in mind for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants