-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat(outputs.influxdb_v2): report selfstats on errors and bytes #17277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Done, the failing integration test is not related to my changes |
@LarsStegman your approach unfortunately has some issues...If people define some tags or an alias your metric it will not be possible to associate your metric to the one of the plugin. However, this is not solvable from within the plugin as it will not have access to this information. I'm working on a PR for allowing plugins to export statistics with those information added. Hope to put up a spec today and I do have a PoC I can share so you can base your PR on. Will share both PRs here later today... Sorry for not solving this issue earlier... |
Hey Sven, no problem. I already suspected I was missing something, because this way of creating stats is not used anywhere else as far as I can see. |
@LarsStegman please let check the spec in PR #17344 and a draft PR for adding the framework in PR #17345. |
Summary
We want to keep track of how many bytes we are sending over a satellite connection, since we sometimes accidentally push away other traffic. I am not sure how (and if) to test these new metrics.
Checklist
Related issues
resolves #17275