Skip to content

test(outputs.sql): Add test for SQL integer time formatting - #17338

Merged
mstrandboge merged 4 commits into
influxdata:masterfrom
srebhan:outputs_sql_issue_17317
Sep 22, 2025
Merged

mstrandboge merged 4 commits into
influxdata:masterfrom
srebhan:outputs_sql_issue_17317

Conversation

@srebhan

@srebhan srebhan commented Jul 15, 2025

Copy link
Copy Markdown
Member

Summary

This PR adds a test for SQLite to mimic the requirements in issue #17317 of storing timestamps as unix-epoch integers in SQLite.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #17317

@telegraf-tiger telegraf-tiger Bot added area/sql plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins test labels Jul 15, 2025
Comment thread plugins/outputs/sql/sqlite_test.go Outdated
Comment thread plugins/outputs/sql/sqlite_test.go Outdated
srebhan and others added 3 commits July 16, 2025 12:03
Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com>
Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com>
@telegraf-tiger

Copy link
Copy Markdown
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
[[amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip] [arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip] [armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip] [armhf.deb i386.rpm freebsd_armv7.tar.gz ] [i386.deb ppc64le.rpm freebsd_i386.tar.gz ] [mips.deb riscv64.rpm linux_amd64.tar.gz ] [mipsel.deb s390x.rpm linux_arm64.tar.gz ] [ppc64el.deb x86_64.rpm linux_armel.tar.gz ] [riscv64.deb linux_armhf.tar.gz ] [s390x.deb linux_i386.tar.gz ] [ linux_mips.tar.gz ] [ linux_mipsel.tar.gz ] [ linux_ppc64le.tar.gz ] [ linux_riscv64.tar.gz ] [ linux_s390x.tar.gz ]]

Comment thread plugins/outputs/sql/sqlite_test.go
Comment thread plugins/outputs/sql/sqlite_test.go
Comment thread plugins/outputs/sql/sqlite_test.go

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Looks good!

@skartikey skartikey removed their assignment Sep 17, 2025
@skartikey skartikey added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 17, 2025
@mstrandboge
mstrandboge merged commit c968df8 into influxdata:master Sep 22, 2025
@github-actions github-actions Bot added this to the v1.36.2 milestone Sep 22, 2025
srebhan added a commit that referenced this pull request Sep 29, 2025
Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com>
(cherry picked from commit c968df8)
skartikey added a commit to skartikey/telegraf that referenced this pull request Sep 30, 2025
…ta#17338)

Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sql plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Efficient SQLITE configuration

4 participants