Fix release submit path resolution, PR response, and catalog search#4
Merged
daniel-garcia merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
…search - release submit: resolve source path through config.ResolveAPIPath() instead of using the bare API id, so module_roots like internal/apis/jsonschema are respected - pr.go: map HTMLURL to json:"html_url" (was "url", which is the API URL not the browser URL) - pr.go: qualify FindExistingPR head param as owner:branch so GitHub filters correctly instead of returning unrelated PRs - jsonschema.go: Lint() now walks directories instead of failing with "is a directory" when given a directory path - resolve.go: prefer local catalog/catalog.yaml when it exists on disk before attempting remote registry auto-discovery - Fix test fixtures and expectations to match corrected behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.ResolveAPIPath()instead of using the bare API id, somodule_rootslikeinternal/apis/jsonschemaare respectedHTMLURLtojson:"html_url"(was"url", which is the API URL not the browser URL)FindExistingPRhead param asowner:branchso GitHub filters correctly instead of returning unrelated PRsLint()now walks directories instead of failing with "is a directory" when given a directory pathcatalog/catalog.yamlwhen it exists on disk before attempting remote registry auto-discoveryTest plan
go test ./internal/publisher/...— updated fixtures forhtml_urlandowner:branchgo test ./internal/validator/...— existing JSON Schema tests passgo test ./...— all unit/integration/testscript tests pass (only e2e skipped, needs K3d)