Add RecordNS support #170
Open
Add RecordNS support #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds AddRecordNS and DeleteRecordNS operations, this is a requirement to extend external-dns with NS record support. Signed-off-by: Dinar Valeev <[email protected]>
There was a problem hiding this comment.
Hi @k0da , Can you please provide us a working example of arguments passed to the CreateNSRecord() function?
| var addresses []ZoneNameServer | ||
| for _, addr := range addr { | ||
| addresses = append(addresses, ZoneNameServer{Address: addr}) | ||
| } |
There was a problem hiding this comment.
Hi @k0da , Can you please add some validations on errors that might rise?
Ex: if recordname == "" {
return nil, fmt.Errorf("recordname must not be empty")
}
| var actualRef string | ||
| var err error | ||
| It("should pass expected NS record Ref to DeleteObject", func() { | ||
| actualRef, err = objMgr.DeleteTXTRecord(deleteRef) |
There was a problem hiding this comment.
Hi @k0da , Please change this DeleteTXTRecord to DeleteNSRecord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds AddRecordNS and DeleteRecordNS operations, this is a
requirement to extend external-dns with NS record support.
Signed-off-by: Dinar Valeev [email protected]