Skip to content

tests : Add unit tests for Alert class#118

Open
Ayoub-Mabrouk wants to merge 6 commits intoinpsyde:3.xfrom
Ayoub-Mabrouk:alertTest
Open

tests : Add unit tests for Alert class#118
Ayoub-Mabrouk wants to merge 6 commits intoinpsyde:3.xfrom
Ayoub-Mabrouk:alertTest

Conversation

@Ayoub-Mabrouk
Copy link
Copy Markdown

This PR adds comprehensive unit tests for the Alert class, covering:

  • LogData interface implementation
  • Level constant verification (550)
  • Independence from channel, context, and message
  • Consistency across multiple calls

@Chrico Chrico requested a review from gmazzap November 28, 2025 12:50
Copy link
Copy Markdown
Contributor

@gmazzap gmazzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thak you for you work.

The code is ok. I would not consider this particular super-helpful as it only tests something that is quite hardcoded in the code.

Also, not sure why of all the Data implemntations, only "Alert" recived the tests.

Finally, the tests could be cleaner using data providers.

However, what stops me from merging is the failed actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants