feat: add UTxO events query and pagination support to state queries#772
Open
whankinsiv wants to merge 3 commits intomainfrom
Open
feat: add UTxO events query and pagination support to state queries#772whankinsiv wants to merge 3 commits intomainfrom
whankinsiv wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: William Hankins <william@sundae.fi>
lowhung
approved these changes
Mar 5, 2026
Collaborator
lowhung
left a comment
There was a problem hiding this comment.
Looks good! Just some comments about the .expect(...) and test names.
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
UtxoEventsRequestwhich will be used as an alternative to the 4 separate query calls needed by theMidnightCNightObservationDataSourcetrait inmidnight-node. This allows us to do server side sorting and capacity limiting, significantly simplifying the client side implementation.Related Issue(s)
Relates to #734
How was this tested?
Checklist
Impact / Side effects
Adds a new request handler and refactors the existing asset and candidate getters to return based on a provided capacity parameter.
Reviewer notes / Areas to focus
Sorting and truncation logic in
modules/midnight_state/src/grpc/utxo_events.rs