WIP cardano-ops as a library
#378
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jul 28, 2021
| pkgs: | ||
| if builtins.pathExists ../globals.nix | ||
| then import ../globals.nix pkgs | ||
| else builtins.trace "globals.nix missing, please add symlink" {} |
There was a problem hiding this comment.
if this is supposed to stop evaluation, you probably want to use throw instead of trace
There was a problem hiding this comment.
@jonringer, this is just code motion -- the original code did trace, not throw.
deepfire
force-pushed
the
cardano-ops-as-a-library
branch
from
22ed80c to
08f5f6b
Compare
deepfire
force-pushed
the
cardano-ops-as-a-library
branch
from
08f5f6b to
4c46adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalsinto a parameter