More sensible back propagation #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximilianAlgehed
force-pushed
the
cant-backpropagation
branch
from
7910561 to
ed45645
Compare
Lucsanszky
reviewed
Sep 17, 2025
Contributor
Lucsanszky
left a comment
Lucsanszky
left a comment
There was a problem hiding this comment.
I have only found a minor typo so far but I will be keep reviewing tomorrow with a fresh pair of eyes.
Lucsanszky
approved these changes
Sep 19, 2025
Contributor
Lucsanszky
left a comment
Lucsanszky
left a comment
There was a problem hiding this comment.
I'm not that familiar with the codebase to confidently approve this, but nonetheless I'll approve in case you are eager to merge. However, it would be good if @Soupstraw could review this too once he is back from his vacation.
Co-authored-by: Lucsanszky <[email protected]>
MaximilianAlgehed
force-pushed
the
cant-backpropagation
branch
from
ddeab33 to
2dcfe17
Compare
Soupstraw
reviewed
Sep 30, 2025
Co-authored-by: Joosep Jääger <[email protected]>
Soupstraw
reviewed
Sep 30, 2025
Soupstraw
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30
The idea here is that instead of having a bunch of special cases to deal with different configurations of
x == E[x']we generalize to propagating both backwards and forwards acrossE[x] == E'[x'], thus unifying previous cases and allowing many more specs to simply work out.