-
Notifications
You must be signed in to change notification settings - Fork 44
chore: add dev adr for guidelines on writting test utilities + remove test_tools
and full
features from mithril-common
#2653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the test_tools
and full
features from mithril-common
and adds guidelines for organizing test utilities, aimed at enhancing Rust compiler artifact reuse and reducing build times.
- Remove
test_tools
andfull
feature flags frommithril-common
to simplify feature management - Update all dependent crates to remove references to these features
- Add new Dev ADR guidelines for organizing crate test utilities
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
mithril-common/Cargo.toml | Remove test_tools and full feature definitions |
mithril-common/src/lib.rs | Remove feature gates from test module |
mithril-common/src/entities/block_range.rs | Remove feature gate from test_extensions module |
mithril-common/src/crypto_helper/cardano/key_certification.rs | Remove feature gate from test_extensions module |
mithril-common/Makefile | Remove feature checking infrastructure |
Multiple Cargo.toml files | Remove test_tools and full feature references from dependencies |
DEV-ADR.md | Add new guidelines for organizing test utilities |
7bf987e
to
20cfc71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏖️
Todo:
|
This limit the available features of `mithril-common` to a minimum, making it easier for rust compiler to reuse build artifacts.
20cfc71
to
2839572
Compare
Content
This PR add a new Dev-Adr entries, "Guidelines for crate test utilities", and remove the
test_tools
andfull
features frommithril-common
in order to enhance Rust compiler ability to reuse built artifacts.Pre-submit checklist
Issue(s)
Closes #2662, Relates to #2580