feat: support Cardano node 10.5
#2664
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Cardano node version 10.5.1 across all three Mithril networks (preview, preprod, and mainnet), upgrading from the previous version 10.4.1. The upgrade includes updating configuration files, network configurations, and documentation to ensure compatibility with the new Cardano node version.
- Updated minimum Cardano node version requirements across all networks
- Modified Cardano node configuration files to use Genesis mode and updated LedgerDB settings
- Updated shell scripts to handle new transaction ID format from Cardano CLI
Reviewed Changes
Copilot reviewed 36 out of 52 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| networks.json | Updated minimum mithril-signer version from 10.3.1 to 10.4.1 for all networks |
| Multiple Docker files | Updated CARDANO_NODE_VERSION from 10.4.1 to 10.5.1 |
| Cargo.toml files | Bumped version numbers for mithril components |
| Config files | Updated Cardano node configurations for 10.5 with Genesis mode and LedgerDB settings |
| Shell scripts | Added handling for new txhash format in transaction processing |
| Documentation | Updated examples and references to use version 10.5.1 |
| CI workflows | Updated test configurations to use new Cardano node version |
| if [[ "\${TX_ID_SUBMITTED}" =~ txhash ]]; then | ||
| TX_ID_SUBMITTED=\$(echo \$TX_ID_SUBMITTED | jq -r '.txhash') |
There was a problem hiding this comment.
The regex pattern matching for 'txhash' should be more specific to avoid false positives. Consider using a more precise pattern like '^."txhash".$' or checking for the JSON structure more robustly.
| if [[ "\${TX_ID_SUBMITTED}" =~ txhash ]]; then | |
| TX_ID_SUBMITTED=\$(echo \$TX_ID_SUBMITTED | jq -r '.txhash') | |
| if echo "\${TX_ID_SUBMITTED}" | jq -e 'has("txhash")' > /dev/null 2>&1; then | |
| TX_ID_SUBMITTED=\$(echo "\$TX_ID_SUBMITTED" | jq -r '.txhash') |
Copilot uses AI. Check for mistakes.
| @@ -97,7 +97,10 @@ function send_funds_to_era_address { | |||
|
|
|||
| ## Compute the submitted transaction id | |||
| TX_ID_SUBMITTED=\$(CARDANO_NODE_SOCKET_PATH=node-pool${N}/ipc/node.sock $CARDANO_CLI \${CURRENT_CARDANO_ERA} transaction txid --tx-file node-pool${N}/tx/tx${N}-era-funds.tx) | |||
|
|
|||
| if [[ "\${TX_ID_SUBMITTED}" =~ txhash ]]; then | |||
There was a problem hiding this comment.
The regex pattern matching for 'txhash' should be more specific to avoid false positives. Consider using a more precise pattern like '^."txhash".$' or checking for the JSON structure more robustly.
Copilot uses AI. Check for mistakes.
jpraynaud
force-pushed
the
jpraynaud/2623-upgrade-cardano-node-10.5
branch
from
ff4afe2 to
db23b63
Compare
* mithril-aggregator from `0.7.79` to `0.7.80` * mithril-signer from `0.2.263` to `0.2.264` * mithril-end-to-end from `0.4.99` to `0.4.100` * mithril-infra/assets/infra.version from `0.4.6` to `0.4.7` * mithril-test-lab/mithril-devnet/VERSION from `0.4.14` to `0.4.15`
jpraynaud
force-pushed
the
jpraynaud/2623-upgrade-cardano-node-10.5
branch
from
db23b63 to
d02b281
Compare
Content
This PR includes the support for Cardano node
10.5:previewpreprodmainnetPre-submit checklist
Issue(s)
Relates to #2623