*usbd_dwc_otg:misaligned membuf#45
Open
alexrayne wants to merge 1 commit intoinsane-adding-machines:masterfrom
Open
*usbd_dwc_otg:misaligned membuf#45alexrayne wants to merge 1 commit intoinsane-adding-machines:masterfrom
alexrayne wants to merge 1 commit intoinsane-adding-machines:masterfrom
Conversation
…unaligned membuffer.
now memory buffer of transfer can be unaligned with negligible price.
! :last bytes store - fixed loose of last loaded from fifo bytes
caused by memcopy call otimisation on keil ARMcc.
| bytes -= 4; | ||
| *mem32++ = *fifo; | ||
| } | ||
| }//if (((uintptr_t)mem & 3) == 0) |
Contributor
|
Are you trying to fix a [single] compiler specific bug in the library? |
Author
|
No, i`ve try to improove FS driver to use misaligned transfers |
Contributor
|
@alexrayne All uC that have this periph have support for unaligned memory access. imo If you write a comment noting the above assumption (unaligned memory access supported is assumed), that would be better. |
Author
|
well, if you`re are wright - it easy to check, just read uint32 from adress xxxx01, and look at HardFault on ARM CM4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provided load/store ep fifo with unaligned transfer membuffer.
! :last bytes store - fixed loose of last loaded from fifo bytes caused by memcopy call otimisation on keil ARMcc.