Skip to content

Fix shared memory errors at cam.get_movie call and iteration #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baharis merged 2 commits into from
May 4, 2026
Merged

Fix shared memory errors at cam.get_movie call and iteration #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09cc73
Fix errors at `cam.get_movie` call and iteration
Baharis Apr 16, 2026
6a5a7b9
When getting data from buffer, copy values instead of taking reference
Baharis Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/instamatic/camera/camera_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def _eval_dct(self, dct):
with self._eval_lock:
self.s.send(dumper(dct))

acquiring_image = dct['attr_name'] in {'get_image', 'get_movie', '__gen_next__'}
acquiring_image = dct['attr_name'] in {'get_image', '__gen_next__'}

if acquiring_image and not self.use_shared_memory:
response = self.s.recv(self._imagebufsize)
Expand All @@ -139,7 +139,7 @@ def _eval_dct(self, dct):
else:
raise RuntimeError(f'Received empty response when evaluating {dct=}')

if self.use_shared_memory and acquiring_image:
if self.use_shared_memory and acquiring_image and data:
data = self.get_data_from_shared_memory(**data)

if status == 200:
Expand Down Expand Up @@ -196,7 +196,7 @@ def get_data_from_shared_memory(self, name: str, shape: tuple, dtype: str, **kwa
print(f'Retrieve data from buffer `{name}`')

buffer = self.buffers[name]
data = buffer[:]
data = buffer[:].copy()

return data

Expand Down
Loading