Skip to content

OIDC login hint #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-perts wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OIDC login hint #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
053a453
feat: support login_hint in auth url
chris-perts Mar 25, 2024
df22b4e
feat: accept login_hint as query string param
chris-perts Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/login/oauth2_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def new
super
nonce = session[:oauth2_nonce] = SecureRandom.hex(24)
jwt = Canvas::Security.create_jwt({ aac_id: @aac.global_id, nonce:, host: request.host_with_port }, 10.minutes.from_now)
authorize_url = @aac.generate_authorize_url(oauth2_login_callback_url, jwt)
authorize_url = @aac.generate_authorize_url(oauth2_login_callback_url, jwt, params[:login_hint])

if @aac.debugging? && @aac.debug_set(:nonce, nonce, overwrite: false)
@aac.debug_set(:debugging, t("Redirected to identity provider"))
Expand Down
6 changes: 4 additions & 2 deletions app/models/authentication_provider/oauth2.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ def client
@client ||= ::OAuth2::Client.new(client_id, client_secret, client_options)
end

def generate_authorize_url(redirect_uri, state)
client.auth_code.authorize_url({ redirect_uri:, state: }.merge(authorize_options))
def generate_authorize_url(redirect_uri, state, login_hint = nil)
options = { redirect_uri: redirect_uri, state: state }
options[:login_hint] = login_hint if login_hint
client.auth_code.authorize_url(options.merge(authorize_options))
end

def get_token(code, redirect_uri, _params)
Expand Down