This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Added the golang client to our e2e testing#78
Open
phansGithub wants to merge 1 commit intointel:mainfrom
Open
Conversation
Contributor
Author
|
Update: Added in GetClientVersion |
patrickog11
reviewed
Nov 14, 2023
Contributor
patrickog11
left a comment
patrickog11
left a comment
There was a problem hiding this comment.
LGTM - just that one issue regarding the CI staticcheck job
.github/workflows/public-ci.yml
Outdated
|
|
||
| - name: Install staticcheck | ||
| run: go install honnef.co/go/tools/cmd/staticcheck@latest | ||
| run: go install honnef.co/go/tools/cmd/staticcheck@latest && go get github.com/intel/afxdp-plugins-for-kubernetes/pkg/goclient |
Contributor
There was a problem hiding this comment.
Can we separate these two commands. Also, must we import github.com/intel/afxdp-plugins-for-kubernetes/pkg/goclient for fresh environments? if it's required each time, it would be worth adding a check before executing the e2e.
Signed-off-by: phansGithub <root@silpixa00401197b.ir.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: due to mixing the client testing with the regular UDS testing, the fix/work around was to run the test with slightly different settings.
Note:
GetClientVersion has not been added yet to the e2e testing as of this comment, will add it in soon.