pm: allow reset when reset type is set #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifenggitacc
force-pushed
the
warm-reboot-reset-prep
branch
from
b2750f0 to
4cb6a19
Compare
Contributor
Author
|
We have done BKC test with this patch, no problem find with it. |
If ISH is busy and not read reset_prep_avail in time, ap could starts its boot flow and clear the bit. To make sure ISH won't miss reboot request, check the reset type also. Signed-off-by: Li Feng <[email protected]>
lifenggitacc
force-pushed
the
warm-reboot-reset-prep
branch
from
4cb6a19 to
cd0f0c9
Compare
Contributor
|
this seems to be a WA, not root caused yet. Do careful full validation to ensure no regression or no harmful side effect. |
ddeshat
reviewed
Mar 19, 2025
ddeshat
previously approved these changes
Mar 19, 2025
ddeshat
left a comment
ddeshat
left a comment
There was a problem hiding this comment.
Minor comment added.
Internal testing reveals that no impact of this change on ISH/System functionality hence approving the change.
kwd-doodling
approved these changes
Mar 19, 2025
ddeshat
approved these changes
Mar 19, 2025
|
@lifenggitacc @tmalhotr we have granted you maintainer's role, please accept. Given this patch is a WA, please revert it when official fix is ready and merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During warm reboot stress test on TWL Google Trulo platform, occasionally ISH main firmware doesn't respond to AP reboot request, this causes kernel module ISHTP failed, and ISH doesn't reboot. The issue is getting easier to duplicate if ISH is busy, for example, enable debug log. The error from kernel log is as below.
[ 5.090396] pci 0000:00:12.0: attach allowed to drvr intel_ish_ipc [internal device]
[ 5.134371] intel_ish_ipc 0000:00:12.0: Dropped Rx msg - no request
[ 12.850196] intel_ish_ipc 0000:00:12.0: waiting for ishtp start failed. ret=0 hbm_state=00000000
[ 12.850210] intel_ish_ipc 0000:00:12.0: HBM haven't started
[ 12.850214] intel_ish_ipc 0000:00:12.0: link layer initialization failed.
[ 12.850218] intel_ish_ipc 0000:00:12.0: ISHTP: Protocol init failed.
PMU set register PMU_RST_PREP bit[1] for reset prep; this bit will be cleared in about 40ms; if ISH AON handle_reset is looking for this bit to reset, if it couldn't read this bit before being cleared, reset request will be missed. But reset type won't get cleared, so the fix is to check both reset type and reset prep, it either is set, will enter reset flow.